src/common/buffer.cc fix judgment for lseek #10130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
better to write the log into commit message, too. otherwise lgtm. |
|
@gaowanlong 😄 Hello,Do you remember the "xiayuhe" stand near by "nanhu" park. |
| @@ -2293,9 +2293,9 @@ int buffer::list::write_fd_zero_copy(int fd) const | |||
| */ | |||
| int64_t offset = ::lseek(fd, 0, SEEK_CUR); | |||
| int64_t *off_p = &offset; | |||
| if (offset < 0 && offset != ESPIPE) | |||
| if (offset < 0 && errno != ESPIPE) | |||
| return (int) offset; | |||
Signed-off-by: zhang.zezhu <zhang.zezhu@zte.com.cn>
yonghengdexin735
force-pushed
the
wip-zzz-add-
branch
from
d06acb3
to
5dcb22a
Compare
|
@xiexingguo thank you for comment, I fixed it |
|
looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lseek() returns the resulting offset location as measured in bytes from the beginning of the file. On error, the value (off_t) -1 is returned and errno is set to indicate the error. And this errno returned ESPIPE.
Signed-off-by: zhang.zezhu zhang.zezhu@zte.com.cn