os/bluestore: change algorithm of compression header from string to int #10137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5770,7 +5770,9 @@ void BlueStore::_do_write_small( | |||
| bdev->aio_write(offset, t, | |||
| &txc->ioc, wctx->buffered); | |||
| }); | |||
| b->blob.calc_csum(b_off, padded); | |||
| if (b->blob.csum_type) { | |||
There was a problem hiding this comment.
IMHO no much sense in this fix as calc_csum performs verification by itself - see corresponding switch inside...
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-05-02
branch
from
c5e61a2
to
cb39a0b
Compare
xiexingguo
changed the title
|
|
||
| return alg; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think these all belong in bluestoer_types.h and cc, probably along side CSUM_*
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-05-02
branch
from
cb39a0b
to
a1af00f
Compare
|
All fixed. |
|
@ifed01 look ok to you? |
| @@ -621,11 +645,11 @@ struct bluestore_wal_transaction_t { | |||
| WRITE_CLASS_ENCODER(bluestore_wal_transaction_t) | |||
|
|
|||
| struct bluestore_compression_header_t { | |||
| std::string type; | |||
| uint8_t type = 0; | |||
There was a problem hiding this comment.
IMHO better use 'type = COM_ALG_NONE' here
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-05-02
branch
from
a1af00f
to
24a15cb
Compare
|
@ifed01 See again? |
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-05-02
branch
from
24a15cb
to
ebff755
Compare
| return COMP_ALG_SNAPPY; | ||
| if (s == "zlib") | ||
| return COMP_ALG_ZLIB; | ||
|
|
There was a problem hiding this comment.
What's about reverse mapping for None ?
The literal description of compression algorithm can vary from various compression types and thus increases the complexity of en/decoding, which as a result can cause chaos. Also it can be more efficient by translating it into a fixed-length type. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-05-02
branch
from
ebff755
to
1209cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The literal description of compression algorithm can vary from
various compression types and thus increases the complexity of
en/decoding, which as a result can cause chaos. Also it can be
more efficient by translating it into a fixed-length type.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn