CMakeList.txt: Fix libraries for ceph_objectstore_tool

[wjwithagen]

• Does not require fuse
• is CMAKE_DL_LIBS instead of dl

Submitted-by: Willem Jan Withagen wjw@digiware.nl

[tchaikov]

ceph-objectstore-tool supports FuseStore if `HAVE_LIBFUSE. in that case we need to link against fuse?

[tchaikov]

could have a dedicated commit for s/dl/${CMAKE_DL_LIBS}/g

[wjwithagen]

On 6-7-2016 10:54, Kefu Chai wrote:

In src/CMakeLists.txt
#10149 (comment):

@@ -612,7 +612,7 @@ add_executable(ceph-objectstore-tool
tools/ceph_objectstore_tool.cc
tools/RadosDump.cc
$<TARGET_OBJECTS:common_util_obj>)
-target_link_libraries(ceph-objectstore-tool osd os global ${Boost_PROGRAM_OPTIONS_LIBRARY} fuse dl)
+target_link_libraries(ceph-objectstore-tool osd os global ${Boost_PROGRAM_OPTIONS_LIBRARY} ${CMAKE_DL_LIBS})

ceph-objectstore-tool supports FuseStore if `HAVE_LIBFUSE. in that case
we need to link against fuse?

I grepped the code, and the only reference was |enable_disable_fuse|,
but there is more HAVE_FUSE parts in src/osd/*
So I guess we'd need to match a WITH_FUSE with the OSD building.

But I'll fix this fuse depedancy for ceph-objectstore-tool in this pull
first.

And the dl <> CMAKE_DL_LIBS fix was just because I was here anyways.
Most of the others are in the FreeBSD cmake changes.
Want me to take 'm out of there and make a separate pull?

[wjwithagen]

@tchaikov
Took the dl <> CMAKE_DL_LIBS into a separate pull #10317.

[wjwithagen]

@tchaikov
Ping.

[tchaikov]

@wjwithagen, sorry, i missed this, could you rebase it against master? and it's good to merge. i think.

[wjwithagen]

@tchaikov
Due to the refactoring of all targets, this also needs to move to another place.
BTW, great work with the refactoring, much more intuitive.

[wjwithagen]

@tchaikov
Thanx,
Care to also merge #10352??