Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: aws4: add presigned url bugfix in runtime #10160

Merged
merged 1 commit into from Dec 16, 2016

Commits on Dec 15, 2016

  1. rgw: aws4: add rgw_s3_auth_aws4_force_boto2_compat conf option

    Runtime bugfix to handle presigned urls computed with canonical requests using
    the port number once.
    
    Boto2 computes canonical requests using the port number twice although it
    should be used once only. This behaviour is a bug supported by AWS S3. Boto2 is
    used in RGW S3 as reference implementation.
    
    The client-side tools not supporting this boto2 bug will fail although they
    should work too.
    
    In order to support both presigned url implementations this patch adds a config
    option to compute a second signature. With this option disabled, the code will
    compute two signatures when the first signature is not valid. The aws4 auth
    succeed if some of the two signatures is valid.
    
    The config option rgw_s3_auth_aws4_force_boto2_compat, is enabled by default so
    one signature, working with boto2, is computed only.
    
    Fixes: http://tracker.ceph.com/issues/16463
    
    Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
    jmunhoz committed Dec 15, 2016
    Copy the full SHA
    078c513 View commit details
    Browse the repository at this point in the history