rgw: better error message when user has no bucket created yet #10162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4817,7 +4817,11 @@ int main(int argc, char **argv) | |||
| string user_str = user_id.to_str(); | |||
| int ret = store->cls_user_get_header(user_str, &header); | |||
| if (ret < 0) { | |||
| cerr << "ERROR: can't read user header: " << cpp_strerror(-ret) << std::endl; | |||
| if (ret == -2) { /* in case of ENOENT */ | |||
There was a problem hiding this comment.
sure, will do in next patch thanks @yehudasa :)
gaurav36
force-pushed
the
bug-16444-radosgw-error-message
branch
from
3d7c5ef
to
2fc2457
Compare
| @@ -4817,7 +4817,11 @@ int main(int argc, char **argv) | |||
| string user_str = user_id.to_str(); | |||
| int ret = store->cls_user_get_header(user_str, &header); | |||
| if (ret < 0) { | |||
| cerr << "ERROR: can't read user header: " << cpp_strerror(-ret) << std::endl; | |||
| if (ret == -ENOENT) { /* in case of ENOENT */ | |||
| cerr << "User has not been initialized " << std::endl; | |||
There was a problem hiding this comment.
User has not been initialized or doesn't exist would be more appropriate here as the same error is thrown when the user doesn't exist as well
gaurav36
force-pushed
the
bug-16444-radosgw-error-message
branch
from
2fc2457
to
913ab64
Compare
| if (ret == -ENOENT) { /* in case of ENOENT */ | ||
| cerr << "User has not been initialized or user does not exist" << std::endl; | ||
| } else { | ||
| cerr << "ERROR: can't read user: " << cpp_strerror(-ret) << std::endl; |
There was a problem hiding this comment.
for posterity, cpp_strerror coerces whatever code is passed to be positive, so there's no need to make a code negative
There was a problem hiding this comment.
@mattbenjamin done.
gaurav36
force-pushed
the
bug-16444-radosgw-error-message
branch
from
913ab64
to
84b0471
Compare
Currently when there is no bucket in the cluster and user execute "$radosgw-admin user stats --uid=testid" command then rgw admin not throwing meaningful error message. With this fix it will show proper meaningful error message. Fixes: http://tracker.ceph.com/issues/16444 Reported-by: Abhishek Lekshmanan <abhishek@suse.com> Signed-off-by: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
gaurav36
force-pushed
the
bug-16444-radosgw-error-message
branch
from
84b0471
to
b9a2048
Compare
|
@oritwas ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when there is no bucket in the cluster and user execute
"$radosgw-admin user stats --uid=testid" command then rgw admin
not throwing meaningful error message.
With this fix it will show proper meaningful error message.
Fixes: http://tracker.ceph.com/issues/16444
Reported-by: Abhishek Lekshmanan abhishek@suse.com
Signed-off-by: Gaurav Kumar Garg garg.gaurav52@gmail.com