os/bluestore: misc cleanups #10201
Merged
os/bluestore: misc cleanups #10201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-08
branch
from
97101ae
to
0cc9781
Compare
| @@ -1465,6 +1465,8 @@ void BlueStore::_set_compression() | |||
| } | |||
| } | |||
| comp_mode = m; | |||
| if (comp_mode == COMP_NONE) | |||
There was a problem hiding this comment.
Probably it's better to avoid compressor allocation at all if mode is inappropriate. I.e. calculate the mode first and then proceed with allocation
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-08
branch
from
0cc9781
to
20cd3a4
Compare
|
@ifed01 Done, please check again! |
| derr << __func__ << " unable to initialize " << alg << " compressor" | ||
| << dendl; | ||
| } | ||
| CompressionMode m; |
There was a problem hiding this comment.
One can omit this and use comp_mode directly...
Some day we might want make this interface more applicable by handling the abnormal cases more gracefully... Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
We are going to break anyway. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-08
branch
2 times, most recently
from
b63dc58
to
ff03296
Compare
|
@ifed01 Upgraded again as per your gorgeous ideas. Please check, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.