hammer: log: do not repeat errors to stderr #10227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we get an error writing to the log, log it only once to stderr. This avoids generating, say, 72 GB of ENOSPC errors in teuthology.log when /var/log fills up. Fixes: ceph#14616 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit d9ac047) Conflicts: src/log/Log.cc (drop m_uid and m_gid which are not used in hammer; order of do_stderr, do_syslog, do_fd conditional blocks is reversed in hammer; drop irrelevant speed optimization code from 5bfe05a)
smithfarm
force-pushed
the
wip-15081-hammer
branch
from
18f809c
to
0498969
Compare
|
This replaces #8077 which was causing an extra blank line to be written to the log after every log entry. Thanks to @athanatos for pointing this out to me! |
|
Hey Jenkins, test this please ! |
smithfarm
added a commit
that referenced
this pull request
Jul 18, 2016
… logs excessively to stderr Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jul 24, 2016
… logs excessively to stderr Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
@liewegas This PR is in the latest round of hammer-backports integration tests, which passed a rados run (the only failures are a valgrind false positive that has since been fixed by ceph/teuthology#915 and http://tracker.ceph.com/issues/15139 which is an infrastructure issue with two of the tests) - for details, see: http://tracker.ceph.com/issues/15895#note-18 I can also confirm that this PR fixed the "extra blank line" issue referred to in #10227 (comment) OK to merge? |
|
lgtm |
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15081