Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: add return value checking to avoid possible subsequent parse exception #10241

Merged
merged 2 commits into from Jul 22, 2016

Conversation

Yan-waller
Copy link
Contributor

add return value checking to avoid possible subsequent parse exception

…xception

Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
@theanalyst
Copy link
Member

the first commit looks good.

I'm not very keen on the tab vs space change.. while I agree we should fix indentation, this does create problems when doing a git blame or when backporting commits... it is fine doing a ws change when you're kind of modifying the code around, lets see what others think of this?

Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
@Yan-waller
Copy link
Contributor Author

Yan-waller commented Jul 12, 2016

@theanalyst thanks for reminding me of the problems when doing a git blame or when backporting commits, that sounds reasonable. I droped that commit, and fix some necessary indents. Could you help to take a look again?

@theanalyst
Copy link
Member

lgtm

@yehudasa yehudasa merged commit 81aef8c into ceph:master Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants