rbd-mirror: include local pool id in resync throttle unique key #10254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: http://tracker.ceph.com/issues/16536 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
lgtm |
| } | ||
| } | ||
|
|
||
| template <typename I> | ||
| void ImageSyncThrottler<I>::cancel_sync(const std::string& local_image_id) { | ||
| void ImageSyncThrottler<I>::cancel_sync(librados::IoCtx &local_io_ctx, |
There was a problem hiding this comment.
Why not just pass the uint64_t pool id instead of the IoCtx object?
There was a problem hiding this comment.
Just to abstract away how the key is formed -- I originally wanted to change the signature to pass in ImageCtxT but that would have involved more work in bootstrap to only cancel if an image sync was scheduled.
trociny
pushed a commit
that referenced
this pull request
Jul 12, 2016
rbd-mirror: include local pool id in resync throttle unique key #10254
trociny
pushed a commit
that referenced
this pull request
Jul 13, 2016
rbd-mirror: include local pool id in resync throttle unique key #10254
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/16536
Signed-off-by: Jason Dillaman dillaman@redhat.com