Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-fuse: link to libtcmalloc or jemalloc #10258

Merged
merged 1 commit into from Jul 14, 2016
Merged

Conversation

ukernel
Copy link
Contributor

@ukernel ukernel commented Jul 12, 2016

Fixes: http://tracker.ceph.com/issues/16655
Signed-off-by: Yan, Zheng zyan@redhat.com

@ukernel ukernel added the cephfs Ceph File System label Jul 12, 2016
@tchaikov
Copy link
Contributor

shall we backport this fix to jewel? as master is not using autotools anymore.

@ukernel
Copy link
Contributor Author

ukernel commented Jul 13, 2016

you mean master is using cmake now? recently I tried using cmake to compile the master several times, most attempts failed.

@tchaikov
Copy link
Contributor

both gitbuilders and jenkins "make check" job are using cmake now. if cmake does not work for you, maybe it's the acconfig.h created by configure?

Fixes: http://tracker.ceph.com/issues/16655
Signed-off-by: Yan, Zheng <zyan@redhat.com>
@ktdreyer
Copy link
Member

@tchaikov any objections to merging this?

@tchaikov
Copy link
Contributor

@ktdreyer no, not at all.

@tchaikov
Copy link
Contributor

tchaikov commented Jul 14, 2016

but shall we have a more general way to link against the allocator libraries instead of linking each executables against $ALLOC_LIBS.

@wjwithagen
Copy link
Contributor

On 14-7-2016 11:21, Kefu Chai wrote:

but shall we have a more general way to link against the allocator
libraries?

My cmake wip (#10024) contains a piece of code where it actually
excludes any allocator libs, since FreeBSD already use jemalloc as
native allocator.

@jcsp
Copy link
Contributor

jcsp commented Jul 14, 2016

Checked this didn't break anything in http://pulpito.ceph.com/jspray-2016-07-13_08:15:02-fs-wip-jcsp-testing-20160713-distro-basic-mira/

@tchaikov @ktdreyer feel free to merge if this is the needed change for jewel (I held off because the last couple of comments made me uncertain)

@tchaikov tchaikov merged commit e5cf8c1 into ceph:master Jul 14, 2016
@tchaikov
Copy link
Contributor

thanks for your input, @wjwithagen. i am merging this change as it is. let's figure out a better way to address it later on.

@tchaikov tchaikov self-assigned this Jul 14, 2016
@wjwithagen
Copy link
Contributor

On 14-7-2016 14:28, Kefu Chai wrote:

thanks for your input, @wjwithagen https://github.com/wjwithagen. i am
merging this change as it is. let's figure out a better way to address
it later on.

As long as ${ALLOC_LIBS} is used it'll keep working as planned.
Because that is the definition I wrapped, and stays empty on FreeBSD.
So as long as this VAR only uses the type of allocator lib, and no more
things will work.

@ukernel ukernel deleted the wip-16655 branch July 15, 2016 03:25
@tchaikov
Copy link
Contributor

tchaikov commented Jul 15, 2016

okay, actually i don't really like how $ALLOC_LIBS is initialized, we should set it to variables like ${Tcmalloc_LIBRARIES}, but that's another story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System
Projects
None yet
5 participants