kv/MemDB: misc fixes and cleanups #10295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MemDB.h has already done such thing. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Also translate the error message to the output properly. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Which is safer. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
1. mkdir() returns zero on success, or -1 if an error occurred (in which case, errno is set appropriately). 2. we shall return the proper error result to caller on failure. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
The string.clear() is stl method, which shall guarantee the string will become empty. So this is absolutely unnecessary. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@chhabaramesh Minor fixes about the newly merged MemDB, can you look? Thanks! |
|
@xiexingguo changes looks ok |
|
@chhabaramesh Thanks, Ramesh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.