pybind: Rework cephfs/setup.py for PyPI #10315
Conversation
| else: | ||
| def cythonize(x, **kwargs): | ||
| return x | ||
|
|
There was a problem hiding this comment.
please remove at least one blank line here.
and could you run this script thru pep8 to kill some warnings.
|
lgtm modulo a pep8 nit. |
Also use `set_include_dirs' in distutils.ccompiler instead of `add_include_dir' for supporting non-standard include directories. Signed-off-by: Anirudha Bose <ani07nov@gmail.com>
|
@tchaikov Thanks. PEP8ified. |
|
@onyb looks like the build bot failure is real - it fails to find librados.h with a cmake build (happens on my machine too). If you haven't built with cmake yet, you should start using it - we're just about all switched over. ceph.git's README.md has updated info on using it. |
Signed-off-by: Anirudha Bose <ani07nov@gmail.com>
|
@jdurgin Fixed the issue. I've tested this with both CMake and configure. |
|
This didn't cause any issues in this run: http://pulpito.ceph.com/jspray-2016-07-19_05:56:13-fs-wip-jcsp-testing-20160719-distro-basic-mira/ Everyone happy to merge? |
|
@jcsp I'm happy to merge |
|
Looks like the doc builders are broken -- the include paths from the environment are no longer processed. |
Also use
set_include_dirsindistutils.ccompilerinstead ofadd_include_dirfor supporting non-standard include directories.