mds: add assertions for standby_daemons invariant #10316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the number of code sites which modify standby_daemons. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
These assertions catch state changes of an mds in standby_daemons to a state other than MDSMap::STATE_STANDBY. Currently this invariant is (sometimes!) checked in other locations on access of standby_daemons. This commit allows us catch the violated invariant at the time it occurred. Related to: http://tracker.ceph.com/issues/16592 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
batrick
force-pushed
the
mds-standby-assertions
branch
from
9941c1f
to
0f044e0
Compare
|
Reviewed-by, will include in next test branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These assertions catch state changes of an mds in standby_daemons to a state
other than MDSMap::STATE_STANDBY. Currently this invariant is (sometimes!)
checked in other locations on access of standby_daemons. This commit allows us
catch the violated invariant at the time it occurred.
Related to: http://tracker.ceph.com/issues/16592
Signed-off-by: Patrick Donnelly pdonnell@redhat.com