debian: python related changes #10322
Conversation
tchaikov
force-pushed
the
wip-debian-python-warnings
branch
2 times, most recently
from
e3ad438
to
42aa32f
Compare
| dh_python2 -O--buildsystem=python_distutils -p python-$$binding; \ | ||
| done | ||
| dh_python2 -p ceph-common | ||
| dh_python2 -O--buildsystem=python_distutils -p ceph-base |
There was a problem hiding this comment.
why --buildsystem=python_distutils? and why not for ceph-common?
There was a problem hiding this comment.
@dmick because i thought these packages install the python extension/modules using python distutils, so i passe -O--buildsystem=python_distutils to dh_python2, and ceph-common just copies the python scripts manually without using distutils, so didn't pass this option.
but seems the result is the same. so i am dropping this option.
|
the build failure is unconnected, most likely, and can be fixed with a rebase I'm assuming |
tchaikov
force-pushed
the
wip-debian-python-warnings
branch
2 times, most recently
from
07149b7
to
9571767
Compare
|
@dmick ping. |
| @@ -134,6 +134,14 @@ override_dh_strip: | |||
| override_dh_shlibdeps: | |||
There was a problem hiding this comment.
the commit message confuses me; if the warning as about running dh_python2 against python-rbd, the code below explicitly does that; did you mean to have a different package name in the warning above?...
There was a problem hiding this comment.
@dmick sorry for the misleading example, yeah, lemme copy another warning message.
some packages do not package python modules or scripts. so override
dh_python2 to exclude them.
this change silences warnings like:
```
warning: dpkg-gencontrol: package ceph-mon: unused substitution
variable ${python:Provides}
```
Signed-off-by: Kefu Chai <kchai@redhat.com>
* debian/control: as we have listed the linked libraries in Depends section, for example, python-rados depends on librados. and we don't need `dpkg-shlibdeps` to help figure out shared library substvar dependencies for us. by removing them, we can silence the warnings of ``` warning: dpkg-shlibdeps: package could avoid a useless dependency if debian/python-rados/usr/lib/python2.7/dist-packages/rados.x86_64-linux-gnu.so was not linked against libpthread.so.0 (it uses none of the library's symbols) ``` -lpthread is introduced by `python-config --ldflags` but it turns out we are not using any symbols from pthread in the extension directly. and pthread is included in glibc. so this does not added any extra dependency to python-* pacakges. but it's desirable to have less warnings. * debian/rules: exclude python-* packages from dh_shlibdeps, as we will not use it to prepare the shlib deps substvars for these packages any more. Signed-off-by: Kefu Chai <kchai@redhat.com>
* debian/control: Build-Depends: s/python-dev/python-all-dev/, per
https://wiki.debian.org/Python/FAQ#Build_dependencies
Signed-off-by: Kefu Chai <kchai@redhat.com>
* ceph-base: use ${python:Depends} instead of listing the python
dependencies manually, dh_python2 will scan the requirements
of ceph-detect-init. and fill the subst var for us.
* ceph-common: add ${python:Depends}, as it packages ceph,
and ceph-brag client.
* ceph-osd: it packages ceph-disk, so should add ${python:Depends}
as its dependencies.
dh_python2 will figure them out.
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-debian-python-warnings
branch
from
9571767
to
f11acf2
Compare
|
@dmick thanks for reviewing, fixed the commit message, rebased against master, and repushed. |
as in #10322 Signed-off-by: Oleh Prypin <oleh@pryp.in>
as in #10322 Signed-off-by: Oleh Prypin <oleh@pryp.in>
@dmick could you take a look at this PR also? thanks.