os/bluestore: add a boundary check of cache read #10349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By trapping the "==" case and break, we can finish the cache read just in time. As a result, we can avoid two extra operations(adjusting "offset" and "length") and the final loop check. Since this is one of key methods of cache, it deserves this fix. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-19
branch
from
ab58efe
to
3bc3174
Compare
xiexingguo
changed the title
|
2016-07-20 17:58:29.861655 7f3524c71680 1 bluestore(store_test_temp_dir) fsck finish with 0 errors [----------] Global test environment tear-down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By trapping the "==" case and break, we can finish
the cache read just in time. As a result, we can avoid
two extra operations(adjusting "offset" and "length") and
the final loop check.
Since this is one of key methods of cache, it deserves this
fix.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn