debian: bump compat to 9 #10366
Merged
debian: bump compat to 9 #10366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it works on my debian box. |
tchaikov
referenced
this pull request
Jul 20, 2016
dh_auto_configure sets CMAKE_BUILD_TYPE=None unconditionally. Work around that by setting it later on the command line to "empty" so that the build type can be set correctly in src/CMakeLists.txt Fixes: http://tracker.ceph.com/issues/16744 Signed-off-by: Dan Mick <dan.mick@redhat.com>
tchaikov
force-pushed
the
wip-cmake-debian
branch
from
09abbbc
to
bdc053e
Compare
|
I totally don't understand how this fixes anything. |
tchaikov
force-pushed
the
wip-cmake-debian
branch
from
bdc053e
to
11fba94
Compare
dh_auto_configure set -DCMAKE_BUILD_TYPE=None so the default does not take effect at all. this is on purpose, see [1]. and dpkg-buildflags is able to produce the suggested compiling flags by debian policy. dh_* can pass these flags to cmake only if it works at compat>=9, see [2]. and we are safe to move to compat 9, as jewel's supported debian based distro is jessie (with debhelper 9.20150101), ubuntu trusty (with debhelper 9.20131227ubuntu1) --- [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=701233#35 [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653916 Fixes: http://tracker.ceph.com/issues/16744 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-cmake-debian
branch
from
11fba94
to
c1c6cfc
Compare
|
@dmick updated the commit message and repushed. |
|
I now understand and agree with the approach. Looking into the build failure |
|
I was waiting to get a clean build sorted, but... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so dpkg-buildflags and dh_* are able to pass appropriate cflags and
ldflags to cmake. and we are safe to move to compat 9, as , as jewel's
supported debian based distro is jessie (with debhelper 9.20150101),
ubuntu trusty (with debhelper 9.20131227ubuntu1)
Fixes: http://tracker.ceph.com/issues/16744
Signed-off-by: Kefu Chai kchai@redhat.com