Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind: Rework rbd/setup.py for PyPI #10376

Merged
merged 2 commits into from Aug 16, 2016
Merged

pybind: Rework rbd/setup.py for PyPI #10376

merged 2 commits into from Aug 16, 2016

Conversation

onyb
Copy link
Contributor

@onyb onyb commented Jul 21, 2016

The RBD test could be better, but this is what QEMU uses in its configure script.

Signed-off-by: Anirudha Bose ani07nov@gmail.com

@dillaman
Copy link

dillaman commented Aug 5, 2016

Please verify that the doc builders are still able to run: https://jenkins.ceph.com/job/ceph-docs/

@tchaikov tchaikov self-assigned this Aug 5, 2016
@tchaikov
Copy link
Contributor

tchaikov commented Aug 5, 2016

@dillaman thanks for catching this. tracked at http://tracker.ceph.com/issues/16940, will take a look at it.

@tchaikov
Copy link
Contributor

tchaikov commented Aug 9, 2016

@dillaman #10623 addresses the issue.

@dillaman
Copy link

dillaman commented Aug 9, 2016

Does this now require the same BUILD_DOC environment variable / skip sanity check logic?

@tchaikov tchaikov removed the needs-qa label Aug 9, 2016
@tchaikov
Copy link
Contributor

tchaikov commented Aug 9, 2016

@dillaman yeah, thanks for the reminder!
@onyb could you please add BUILD_DOC env var as well? see #10623.

@tchaikov tchaikov assigned onyb and unassigned tchaikov Aug 9, 2016
Signed-off-by: Anirudha Bose <ani07nov@gmail.com>
Bypass sanity check if building docs.
Issue: http://tracker.ceph.com/issues/16940

Signed-off-by: Anirudha Bose <ani07nov@gmail.com>
@onyb
Copy link
Contributor Author

onyb commented Aug 10, 2016

@tchaikov Done. Thanks!

@tchaikov
Copy link
Contributor

lgtm.

@dillaman
Copy link

lgtm

@tchaikov tchaikov assigned tchaikov and unassigned onyb Aug 10, 2016
@jdurgin jdurgin merged commit 0b84e0d into ceph:master Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants