cmake changes #10391
Merged
cmake changes #10391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please. |
| @@ -5,3 +5,11 @@ if(WITH_SUBMAN) | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/subman | |||
| DESTINATION ${CMAKE_INSTALL_SYSCONFDIR}/cron.hourly) | |||
| endif() | |||
|
|
|||
| configure_file( | |||
There was a problem hiding this comment.
@markhpc maybe you will like this!
libuuid dependency is not found in ceph.spec.in or debian/control. and we are not using libuuid since 62bfc7a. Signed-off-by: Kefu Chai <kchai@redhat.com>
use find_package_handle_standard_args() and remove unused bits. Signed-off-by: Kefu Chai <kchai@redhat.com>
* use find_package_handle_standard_args() and remove unused bits. * rename OPENLDAP_LIBS to OPENLDAP_LIBRARIES, to be consistent with find_package() modules. Signed-off-by: Kefu Chai <kchai@redhat.com>
it is used by ceph.spec.in for installing subscription manager cron job on rhel. Signed-off-by: Kefu Chai <kchai@redhat.com>
following https://cmake.org/Wiki/RecipeAddUninstallTarget Signed-off-by: Kefu Chai <kchai@redhat.com>
FindBacktrace.cmake is missing in older versions of cmake. so put a copy in our tree. Signed-off-by: Kefu Chai <kchai@redhat.com>
* we don't need the BABELTRACE_PATH_HINT setting, as packaging script requires the the babeltrace pacakges explicitly. Signed-off-by: Kefu Chai <kchai@redhat.com>
for example
```
include_directories(${LEVELDB_PREFIX}/include)
```
does not make sense if `LEVELDB_PREFIX` is not defined.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* we used to check the header file of "aio.h" which is part of glibc, the glibc async i/o, and the corresponding library is librt. but what we are using is libaio. * reference libaio using AIO_LIBRARIES for consistency. Signed-off-by: Kefu Chai <kchai@redhat.com>
* remove unused bits * fix the wrong mark_as_advanced() call. Signed-off-by: Kefu Chai <kchai@redhat.com>
remove the crufts for handling the REQUIRED argument. Signed-off-by: Kefu Chai <kchai@redhat.com>
remove unused bits Signed-off-by: Kefu Chai <kchai@redhat.com>
this behaviour matches the autotools. and we should not enable profiling unless asked to do so. Fixes: http://tracker.ceph.com/issues/16804 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
@mdw-at-linuxbox could you look over the changes in FindOpenLdap.cmake? |
as we don't need to compile the whole mds just for building the libcephfs Signed-off-by: Kefu Chai <kchai@redhat.com>
|
@tchaikov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.