ceph-create-keys: fix existing-but-different case #10415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just have to refrain from calling get-or-create if the named key already exists, to avoid potentially having an error when the default creation args don't match the key as it has already been created, such as on certain upgrades. Fixes: http://tracker.ceph.com/issues/16255 Signed-off-by: John Spray <john.spray@redhat.com>
|
This looks OK to me |
| 'ceph', | ||
|
|
||
| args_prefix = [ | ||
| "ceph", |
There was a problem hiding this comment.
nit, s/"/'/ for consistency.
|
lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just have to refrain from calling get-or-create
if the named key already exists, to avoid potentially
having an error when the default creation args don't
match the key as it has already been created, such
as on certain upgrades.
Fixes: http://tracker.ceph.com/issues/16255
Signed-off-by: John Spray john.spray@redhat.com