jewel: cli: ceph command line tool chokes on ceph –w (the dash is unicode 'en dash' &ndash, copy-paste to reproduce) #10420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleh Prypin <oleh@pryp.in> (cherry picked from commit ddf0604)
Signed-off-by: Oleh Prypin <oleh@pryp.in> (cherry picked from commit bef2c83)
we raise UnicodeDecodeError at seeing non-ascii args if we fail to match it with any command signatures. instead, we should use a unicode string for representing the error in that case. please note, the exception is not printed at all in real-world. =) Fixes: http://tracker.ceph.com/issues/12287 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 5864626)
|
Backport of 5864626 along with two commits to make it apply cleanly. |
ghost
pushed a commit
that referenced
this pull request
Aug 8, 2016
…ph –w (the dash is unicode 'en dash' &ndash, copy-paste to reproduce) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 9, 2016
…ph –w (the dash is unicode 'en dash' &ndash, copy-paste to reproduce) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 12, 2016
…ph –w (the dash is unicode 'en dash' &ndash, copy-paste to reproduce) Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@tchaikov does this backport look good to merge ? It passed the rados suite http://tracker.ceph.com/issues/16344#note-17 (except for one known bug that is, I believe, unrelated). |
|
@smithfarm thanks for cherry-picking the commits depended by my change also. @dachary lgtm. |
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16798