os/bluestore: proper handling for csum enable/disable settings #10431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 25, 2016 16:36
Signed-off-by: Igor Fedotov <ifed@mirantis.com>
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
|
lgtm |
|
Hmm, I wonder if it makes sense to have a different option for this (verify csum on read)? That way you can separately disable all the csum checks on read, which might be useful/interesting anyway. |
|
@liewegas Would you want the hypothetical option as a separate PR? (IE are we good to go on this one?) |
|
@liewegas I think that's a nice option with a very little use.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to read 'csum aligned' chunks when reading with csum verification disabled. Hence we can tune read performance.
Signed-off-by: Igor Fedotov ifedotov@mirantis.com