Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add client config ref #10434

Merged
merged 1 commit into from Jul 29, 2016
Merged

doc: add client config ref #10434

merged 1 commit into from Jul 29, 2016

Conversation

batrick
Copy link
Member

@batrick batrick commented Jul 25, 2016

Fixes: http://tracker.ceph.com/issues/16743

Signed-off-by: Patrick Donnelly pdonnell@redhat.com

@batrick
Copy link
Member Author

batrick commented Jul 25, 2016

There are a few config option descriptions that I'm unsure on (marked by FIXME). Could use some suggestions.


``client_max_inline_size``

:Description: **FIXME**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the largest a file can be and still get inlined (i.e. stored in the inode instead of in a data object). Only applies if the inline_data flag is set in the mdsmap.

@batrick
Copy link
Member Author

batrick commented Jul 26, 2016

Done, thanks @jcsp.


``client_oc``

:Description: Enable object caching.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we know if this works, or really expect it to? (Disabling it, that is.) we probably shouldn't document it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest marking the config option as ignored and removing the checks in the code.

@gregsfortytwo
Copy link
Member

Do we really want to point people at the monitor-routed inject-arts instead of the admin socket config set? :/

@batrick batrick force-pushed the i16743 branch 2 times, most recently from 09c7336 to f2ed83e Compare July 27, 2016 20:48
Fixes: http://tracker.ceph.com/issues/16743

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
Copy link
Member Author

batrick commented Jul 27, 2016

Thanks for the suggestions Greg. I amended the commit.

@jcsp jcsp merged commit df0720c into ceph:master Jul 29, 2016
@batrick batrick deleted the i16743 branch July 29, 2016 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants