osd: cleanup options and other redundancies #10450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@athanatos Can you look? Thanks! |
| OPTION(osd_compression_plugins, OPT_STR, | ||
| "zlib" | ||
| " snappy" | ||
| ) // list of compression plugins | ||
| OPTION(osd_pool_default_erasure_code_profile, |
There was a problem hiding this comment.
@Ved-vampir Is this ok to remove?
There was a problem hiding this comment.
@athanatos Now it isn't used, so, yes.
|
Once you address those comments, ping me and I'll add needs-qa. |
It is not used anywhere and removing the unnecessary code is always the preferred option. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Because the lock_suspend_timeout() process of PG does the same thing for each loop. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
The is_up() check implicitly coveres the exist() check, so below here the exist() check is not necessary. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-cleanup-options
branch
from
6109b0c
to
b211257
Compare
|
@athanatos Done and thanks for the review. |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.