test: break out librados-using cephfs test #10452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing an issue due to the lockdep symbols in libcephfs and librados clashing, which shows itself after a fork in the flock tests. We can avoid this by splitting the libcephfs tests that require librados (access.cc) into their own compilation unit so that the flock tests can run in a libcephfs-only process. Fixes: http://tracker.ceph.com/issues/16556 Signed-off-by: John Spray <john.spray@redhat.com>
|
#10472 is the PR. |
|
@jcsp @badone and me were discussing this issue this morning, probably we can do fork() in a safer way? see http://tracker.ceph.com/issues/16556#note-11. |
|
I'll close this once we've seen a fs suite pass with #10472 (which has now merged) |
|
I'm merging this because without it #9566's tests were failing (presumably due to who-knows-what other fork()-related weirdness that I don't want to investigate right now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing an issue due to the lockdep symbols
in libcephfs and librados clashing, which shows itself
after a fork in the flock tests. We can avoid this
by splitting the libcephfs tests that require librados
(access.cc) into their own compilation unit so that
the flock tests can run in a libcephfs-only process.
Fixes: http://tracker.ceph.com/issues/16556
Signed-off-by: John Spray john.spray@redhat.com