Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: fixup param type and return value #10463

Merged
merged 1 commit into from Sep 23, 2016
Merged

Client: fixup param type and return value #10463

merged 1 commit into from Sep 23, 2016

Conversation

gongchuang
Copy link
Contributor

@gongchuang gongchuang commented Jul 28, 2016

optimization param type of make_request;

Signed-off-by: gongchuang gong.chuang@zte.com.cn

@songbaisen
Copy link

@gongchuang First you should put your two commit into one commit.
second, here look like build error.

@yonghengdexin735
Copy link
Contributor

@gongchuang hi, I think adding '-' to return value is unnecessary,
r = cfuse->init(newargc, newargv); if (r != 0) { cerr << "ceph-fuse[" << getpid() << "]: fuse failed to initialize" << std::endl; goto out_messenger_start_failed; }
here is the judgment for return value.

@songbaisen
Copy link

@yonghengdexin735 Wa,ou. Bang,Bang.

@batrick batrick added cephfs Ceph File System needs-review labels Jul 30, 2016
@jcsp
Copy link
Contributor

jcsp commented Aug 2, 2016

Was there any particular reason for changing the sign of the error return codes? Was it breaking something?

The other (mds_rank) type change looks fine.

@gongchuang
Copy link
Contributor Author

@jcsp no ohter reason,because i see FuseStore::start return negative value.for unified forms.

@jcsp
Copy link
Contributor

jcsp commented Sep 6, 2016

@gongchuang those return codes get passed out as the status on the command line, which is a positive value: I don't think it's helpful to try and pass negative codes there.

Please remove the commit that changes the return values, and I'll merge this.

@jcsp jcsp removed their assignment Sep 6, 2016
Signed-off-by: gongchuang <gong.chuang@zte.com.cn>
@jcsp
Copy link
Contributor

jcsp commented Sep 12, 2016

@gongchuang ping

@gongchuang
Copy link
Contributor Author

retest this please

@jcsp jcsp merged commit dd46c78 into ceph:master Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System needs-review
Projects
None yet
5 participants