Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/CMakeLists.txt: remove unneeded libraries from ceph-dencoder target #10478

Merged
merged 1 commit into from Aug 10, 2016

Conversation

wjwithagen
Copy link
Contributor

No description provided.

@wjwithagen wjwithagen force-pushed the wip-wjw-freebsd-cmake-excludes branch 3 times, most recently from 358f831 to 0136619 Compare July 28, 2016 20:21
@tchaikov
Copy link
Contributor

test this please.

@wjwithagen
Copy link
Contributor Author

@tchaikov
On the FreeBSD end it works perfectly.
On my CentOS box it compiles with problem
Running in Jenkins in ran into trouble during tests.

I guess you've obviously fixed something.
But I think it deserves a bit more hammering in theuthology?

@tchaikov
Copy link
Contributor

@wjwithagen jenkins passed. it ran into some irrelevant issue, i believe.

@tchaikov
Copy link
Contributor

retest this please. (try again to see if it's reproducible)

@tchaikov
Copy link
Contributor

tchaikov commented Aug 1, 2016

@wjwithagen needs rebase.

@tchaikov
Copy link
Contributor

tchaikov commented Aug 1, 2016

lgtm

@tchaikov
Copy link
Contributor

tchaikov commented Aug 3, 2016

@wjwithagen could you update the commit message? it now reads "fix rebase".

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@wjwithagen wjwithagen force-pushed the wip-wjw-freebsd-cmake-excludes branch from 2ad94e7 to 80398f0 Compare August 6, 2016 21:08
@wjwithagen
Copy link
Contributor Author

@tchaikov
This is a general commit, good for all architectures

@tchaikov
Copy link
Contributor

all unit tests (check-generated.sh,readable.sh) involving ceph-dencoder passed.

@tchaikov tchaikov merged commit 2bebfa4 into ceph:master Aug 10, 2016
@tchaikov tchaikov self-assigned this Aug 10, 2016
@wjwithagen wjwithagen deleted the wip-wjw-freebsd-cmake-excludes branch January 23, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants