cmake changes #10489
Merged
cmake changes #10489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-cmake
branch
2 times, most recently
from
f1adf26
to
a03ac8b
Compare
|
retest this please. |
|
librbd changes lgtm |
missed it in 0edfad0. * librbd: pass '--exclude-libs,ALL' to linker * rbd: link against used libraries explicitly, rbd is accessing some internal symbols not exposed by librbd. Signed-off-by: Kefu Chai <kchai@redhat.com>
crush is not used in erasure plugins at this moment. Signed-off-by: Kefu Chai <kchai@redhat.com>
as it is replaced by the boost implementation, and not detected in cmake anymore. Signed-off-by: Kefu Chai <kchai@redhat.com>
this makes sure we are compatible with latest and future cmake Signed-off-by: Kefu Chai <kchai@redhat.com>
better off using the detected path, instead of using the default path for finding the linked libaries. see "cmake --help-policy CMP0065" for more details. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
* AIO_LIBS is now named AIO_LIBARIES, and there is not point to print out its path * USE_NSS is not defined if NSS is not checked, so if(USE_NSS) is better here. Signed-off-by: Kefu Chai <kchai@redhat.com>
* remove unused stuff, we do not pass/use FUSE_VERSION in cmake. the FUSE_VERSION we are using is defined by "fuse_common.h". * use FindPackageHandleStandardArgs for handling find_package() arguments. * also detect osxfuse on MacOS. Signed-off-by: Kefu Chai <kchai@redhat.com>
|
changelog
|
as Thread.cc lives in libcommon, and global is not using libpthread directly. so moving libpthread linkage from libglobal to libcommon. Signed-off-by: Kefu Chai <kchai@redhat.com>
|
retest this please. |
|
gitbuilders are happy. per discussion with @alimaredia over irc, the PR looks good to him. so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.