Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/common/dns_resolve.cc: reorder the includes #10505

Merged
merged 2 commits into from Aug 2, 2016

Conversation

wjwithagen
Copy link
Contributor

  • dns_resolv.h should only be include after all the std-includes are
    made. Otherwise it will result into undefined structs/variables on
    FreeBSD/Clang

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

 - dns_resolv.h should only be include after all the std-includes are
   made. Otherwise it will result into undefined structs/variables on
   FreeBSD/Clang

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@cbodley
Copy link
Contributor

cbodley commented Jul 29, 2016

can we try to fix dns_resolve.h instead, so we don't have to worry about other source files that include it? the header itself should include all of its dependencies

@wjwithagen
Copy link
Contributor Author

wjwithagen commented Jul 29, 2016

@cbodley
That is a more invasive fix, but makes perfect sense.
Although the coding standard actually requires to first include the system include files
and only then the local project include files. (exceptions left aside)

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@wjwithagen
Copy link
Contributor Author

please retest this

@xiexingguo
Copy link
Member

@wjwithagen
retest this please

shall work:-)

@wjwithagen
Copy link
Contributor Author

@xiexingguo
I was wondering.... Thanx.

@cbodley cbodley merged commit 4d95e5c into ceph:master Aug 2, 2016
@wjwithagen wjwithagen deleted the wip-wjw-dns-resolv branch January 23, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants