jewel: rgw: segmentation fault on error_repo in data sync #10523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGWDataSyncShardCR will only allocate an error_repo if it's doing incremental sync, so RGWDataSyncSingleEntryCR needs to guard against a null error_repo also, RGWDataSyncShardCR::stop_spawned_services() was dropping the last reference to the error_repo before calling drain_all(), which meant that RGWDataSyncSingleEntryCR could still be holding a pointer. now uses a boost::intrusive_ptr in RGWDataSyncSingleEntryCR to account for its reference Fixes: http://tracker.ceph.com/issues/16603 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 2860902)
ghost
pushed a commit
that referenced
this pull request
Aug 8, 2016
…po in data sync Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 9, 2016
…po in data sync Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 12, 2016
…po in data sync Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@cbodley does this backport look good to merge ? It passed the rgw suite http://tracker.ceph.com/issues/16344#note-19 (the failure was due to another pull request). |
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16700