osd: minor performance improvements and fixes #10526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which is never used by anyone. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-misc-2016-07-30
branch
2 times, most recently
from
84fe526
to
60ff0ec
Compare
|
@athanatos Please take a look. Thanks! |
| @@ -949,13 +949,13 @@ class OSDService { | |||
| Mutex::Locker l(recovery_lock); | |||
| _maybe_queue_recovery(); | |||
| } | |||
| void clear_queued_recovery(PG *pg, bool front = false) { | |||
| void clear_queued_recovery(PG *pg) { | |||
There was a problem hiding this comment.
Actually, this one may come to life again soon, please remove this commit.
For now BlueStore is the only caller of set_bitwise_key_u32(), and it will always passed in hash_reverse_bits. Since this is one of the basic and key method of BlueStore, it makes sense to make it a little faster. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
1. these counters are of type atomic_t and are public-access safe. 2. since the tick() thread requires the big osd_lock and thus may not tick at a constant interval, it is good for accuracy and performance to move the buffer-related stats to the tick_without_osd_lock() thread instead. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
By moving the buffer-related stats into tick_without_osd_lock(), we are already accurate enough updating period of these counters. So there is no need to do this in this time-senstive method, which holds the big osd_lock. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Because we are going to return anyway under this case. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
We may use osd_mon_ack_timeout the following way:
double backoff = stats_ack_timeout / g_conf->osd_mon_ack_timeout;
which is at risk of precision lost.
Example:
main()
{
double r = 5 / 30;
cout << "r = " << r << std::endl;
}
Output:
r = 0
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-misc-2016-07-30
branch
from
60ff0ec
to
966c7c2
Compare
|
@athanatos Done and thanks for the confirmation. |
xiexingguo
force-pushed
the
xxg-wip-misc-2016-07-30
branch
from
cba31f5
to
73a9b56
Compare
|
@xiexingguo I haven't reviewed those 4 new ones. I'd appreciate it if you did not add more commits to a PR after I've reviewed the PR and added the needs-qa label... Please remove them and ping me so that I can re-add the needs-qa label. |
xiexingguo
force-pushed
the
xxg-wip-misc-2016-07-30
branch
from
73a9b56
to
966c7c2
Compare
@athanatos Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.