Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon/HealthMonitor: add override to virtual functs #10549

Merged
merged 1 commit into from Sep 18, 2016
Merged

mon/HealthMonitor: add override to virtual functs #10549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/mon/HealthMonitor.h
View file
Open in desktop
Expand Up @@ -25,7 +25,7 @@ class HealthMonitor : public QuorumService
map<int,HealthService*> services;

protected:
virtual void service_shutdown();
void service_shutdown() override;

public:
HealthMonitor(Monitor *m) : QuorumService(m) { }
Expand All @@ -38,20 +38,20 @@ class HealthMonitor : public QuorumService
* @defgroup HealthMonitor_Inherited_h Inherited abstract methods
* @{
*/
virtual void init();
virtual void get_health(Formatter *f,
list<pair<health_status_t,string> >& summary,
list<pair<health_status_t,string> > *detail);
virtual bool service_dispatch(MonOpRequestRef op);
void init() override;
void get_health(Formatter *f,
list<pair<health_status_t,string> >& summary,
list<pair<health_status_t,string> > *detail) override;
bool service_dispatch(MonOpRequestRef op) override;

virtual void start_epoch() {
void start_epoch() override {
for (map<int,HealthService*>::iterator it = services.begin();
it != services.end(); ++it) {
it->second->start(get_epoch());
}
}

virtual void finish_epoch() {
void finish_epoch() override {
generic_dout(20) << "HealthMonitor::finish_epoch()" << dendl;
for (map<int,HealthService*>::iterator it = services.begin();
it != services.end(); ++it) {
Expand All @@ -60,14 +60,14 @@ class HealthMonitor : public QuorumService
}
}

virtual void cleanup() { }
virtual void service_tick() { }
void cleanup() override { }
void service_tick() override { }

virtual int get_type() {
int get_type() override {
return QuorumService::SERVICE_HEALTH;
}

virtual string get_name() const {
string get_name() const override {
return "health";
}

Expand Down