Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: specify distutils build path explicitly #10568

Merged
merged 1 commit into from Aug 10, 2016

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Aug 4, 2016

so we don't need to replicate the logic in distutils/command/build.py
at different places.

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov
Copy link
Contributor Author

tchaikov commented Aug 4, 2016

@wjwithagen this addresses the distutils build path issue also.

@wjwithagen
Copy link
Contributor

@tchaikov
Looks like it would do.
ATM got other things to tend to, but perhaps I can give it a testrun tonight.

@tchaikov
Copy link
Contributor Author

tchaikov commented Aug 4, 2016

@wjwithagen thanks in advance!

@alimaredia
Copy link
Contributor

@mdw-at-linuxbox what do you think about this?

@wjwithagen
Copy link
Contributor

@tchaikov
Is there an easy way to get a diff or something I can run thru patch?
Otherwise I need to start editing 6 files manually

@tchaikov
Copy link
Contributor Author

tchaikov commented Aug 4, 2016

@wjwithagen

what you do you mean by get a diff? you mean get a patch of this PR, for example? if that's the case, you can using following command to create a local branch named "wip-10568" has the change in this PR.

git fetch -f origin pull/10568/head:wip-10568

@wjwithagen
Copy link
Contributor

@tchaikov
Nice command... Goes in the list to remember

Test completed, and my coverage has not changed.
So ceph kan definitly still find the rados.so lib it required.

@wjwithagen
Copy link
Contributor

lgtm

@tchaikov
Copy link
Contributor Author

tchaikov commented Aug 9, 2016

@alimaredia @mdw-at-linuxbox if no objections i will merge this PR.

so we don't need to replicate the logic in distutils/command/build.py
at different places.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

rebased against master and resolved conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants