Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExclusiveArch for openSUSE #10590

Closed
wants to merge 2 commits into from
Closed

ExclusiveArch for openSUSE #10590

wants to merge 2 commits into from

Conversation

michelmno
Copy link
Contributor

No description provided.

@michelmno
Copy link
Contributor Author

@smithfarm the master branch upstream has missing changes versus OBS, so not sure I should base my work on it. any suggestion ?

@michelmno
Copy link
Contributor Author

I understand what to do for the the signed-off, but waiting for other comments before to pursue

@smithfarm
Copy link
Contributor

smithfarm commented Aug 5, 2016

@michelmno Yes, the changes will need to be backported to jewel and cherry-picked to our downstream branch, but I can take care of that.

The best way to proceed IMO is to open a tracker ticket for each change, and open one PR for each tracker ticket. That way each change can be reviewed separately and we hopefully won't get too confused.

To start with, I opened http://tracker.ceph.com/issues/16936 for the ExclusiveArch.

Can you go ahead an open a ticket for the LTTng change? Registration on http://tracker.ceph.com is easy and you automatically get enough permissions to open a ticket.

Then, in the git commit message, include a line (immediately preceding Signed-off-by:) that says

Fixes: http://tracker.ceph.com/issues/$ISSUE_NUMBER

@smithfarm smithfarm self-assigned this Aug 5, 2016
@smithfarm
Copy link
Contributor

@michelmno While you're adding Signed-off-by, please add the Fixes: line to the ExclusiveArch commit as well.

@smithfarm
Copy link
Contributor

It would be preferable to have the ExclusiveArch commit here, and the LTTng-ust commit in the other PR.

@smithfarm
Copy link
Contributor

oh... I see you're opening PRs from your master branch. You'll need to make a wip branch for each PR. For example:

git remote add ceph git://github.com/ceph/ceph
git fetch ceph
git checkout -b wip-16936 ceph/master
(add commit fixing  http://tracker.ceph.com/issues/16936 )
git push -u origin wip-16936
(open PR)

@michelmno
Copy link
Contributor Author

as suggested I am tracking related changes in two different PR, in fact creating two new ones and closing this first one.

http://tracker.ceph.com/issues/16936 about ExclusiveArch
#10594

http://tracker.ceph.com/issues/16937 about lttng for openSUSE
#10592

@michelmno michelmno closed this Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants