New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jewel: build/ops: 60-ceph-partuuid-workaround-rules still needed by debian jessie (udev 215-17) #10653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceph-disk activate-all walks /dev/disk/by-parttypeuuid at boot time. It is not necessary when udev fires ADD event for each partition and 95-ceph-osd.rules gets a chance to activate a ceph disk or journal. There are various reasons why udev ADD events may not be fired at boot (for instance Debian Jessi 8.5 never does it and CentOS 7.2 seems to be racy in that regard when a LVM root is being used). Populating /dev/disk/by-parttypeuuid fixes ceph-disk activate-all that would not work without it. And it guarantees disks are activated at boot time regardless of wether udev fires ADD events at the right time (or at all). The new udev file is a partial resurection of the 60-ceph-partuuid-workaround-rules that was removed by 9f77244. It is given a name that reflects its new purpose. Fixes http://tracker.ceph.com/issues/16351 Signed-off-by: Loic Dachary <loic@dachary.org> (cherry picked from commit 35004a6)
error: Installed (but unpackaged) file(s) found: /usr/lib/udev/rules.d/60-ceph-by-parttypeuuid.rules Signed-off-by: runsisi <runsisi@zte.com.cn> (cherry picked from commit 49dfad1)
ghost
added this to the jewel milestone
Aug 10, 2016
ghost
self-assigned this
Aug 10, 2016
ghost
mentioned this pull request
Aug 10, 2016
ghost
pushed a commit
that referenced
this pull request
Aug 12, 2016
…still needed by debian jessie (udev 215-17) Reviewed-by: Loic Dachary <ldachary@redhat.com>
test this please (bluefs crash) |
ghost
pushed a commit
that referenced
this pull request
Aug 16, 2016
…still needed by debian jessie (udev 215-17) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 17, 2016
…still needed by debian jessie (udev 215-17) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…still needed by debian jessie (udev 215-17) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…still needed by debian jessie (udev 215-17) Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 23, 2016
…still needed by debian jessie (udev 215-17) Reviewed-by: Loic Dachary <ldachary@redhat.com>
Passed upgrade tests http://tracker.ceph.com/issues/16344#note-29 |
ghost
changed the title
jewel : 60-ceph-partuuid-workaround-rules still needed by debian jessie (udev 215-17)
jewel: build/ops: 60-ceph-partuuid-workaround-rules still needed by debian jessie (udev 215-17)
Aug 25, 2016
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16577