os/bluestore: fix locking for finish_write #10665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-bluestore-finish-write
branch
from
612e6ce
to
f9de579
Compare
In 0633c71 we adding locking (which we need), but used first_collection, which may not be the right collection for the given onode. Add an onode->collection pointer so that we can lock the correct thing. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore-finish-write
branch
from
f9de579
to
3d6f4e2
Compare
|
#10215 is a better fix |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0633c71 we adding
locking (which we need), but used first_collection,
which may not be the right collection for the given
onode. Add an onode->collection pointer so that we can
lock the correct thing.
Signed-off-by: Sage Weil sage@redhat.com