cmake: install platlib into a subdir of build-base dir #10666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should wait until gb are happy. i failed to do so last time... |
|
jenkins failed - perhaps need to adjust AddCephTest again |
distutils' install command installs all stuff under $build-base, which includes the temporary files. and rpm packaging does not like:: Installed (but unpackaged) file(s) and to support both py2 and py3, we should encode the python version into the path, otherwise the built files will be overwritten. Signed-off-by: Kefu Chai <kchai@redhat.com>
|
@jdurgin thanks. fixed and repushed |
|
lgtm if the gitbuilders pass |
|
they are happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils' install command installs all stuff under $build-base, which
includes the temporary files. and rpm packaging does not like::
Installed (but unpackaged) file(s)
and to support both py2 and py3, we should encode the python version
into the path, otherwise the built files will be overwritten.
Signed-off-by: Kefu Chai kchai@redhat.com