rgw: fix is_admin handling in RGWLDAPAuthEngine and introduce acct_privilege_t #10687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
| @@ -120,15 +120,20 @@ class RGWRemoteAuthApplier : public RGWAuthApplier { | |||
| const uint32_t acct_type; | |||
|
|
|||
| public: | |||
| enum class acct_privilage_t { | |||
There was a problem hiding this comment.
@cbodley: thanks for pointing this out, Casey! Updated.
|
@rzarzynski : Looks fine to me. |
…ure. Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
rzarzynski
force-pushed
the
wip-rgw-is_admin-fix
branch
from
fb5537b
to
32a04b0
Compare
rzarzynski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pritha-srivastava, @mattbenjamin: I'm sending the PR early. It still needs some testing.