bluestore: do not use freelist to track bluefs_extents #10698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We explicitly track bluefs extents in the bluefs_extents interval_set stored in the superblock. Telling the freelist about it is redundant. It's also slow, because bluefs uses a bit portion of the device and the bitmap representation has to flip a lot of bits in the KV store during mkfs (or possibly during a freespace balance). Signed-off-by: Sage Weil <sage@redhat.com>
In init_add_free we only use the min_alloc_size aligned portion of the provided extent. Since we have some callers that add in free space and then take it back, make init_rm_free do the same. That way we can, e.g, init_add_free 0x1000~0x400000000 (alloc will add 0x10000~0x3ffffff0000) and then init_rm_free 0x1000~0x100000 (alloc will remove 0x10000~0xf0000). Signed-off-by: Sage Weil <sage@redhat.com>
The only other instance of FreelistManager defines this differently anyway. Signed-off-by: Sage Weil <sage@redhat.com>
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We track these explicitly in the bluestore superblock in bluefs_extents--we
dont' need to flip bits. This speeds up mkfs and balancing significantly.