rbd-mirror: improve split-brain detection logic #10703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
pushed a commit
that referenced
this pull request
Aug 14, 2016
rbd-mirror: improve split-brain detection logic #10703
| @@ -982,6 +982,10 @@ void ImageReplayer<I>::allocate_local_tag() { | |||
| predecessor_mirror_uuid = librbd::Journal<>::LOCAL_MIRROR_UUID; | |||
| } | |||
|
|
|||
| dout(20) << "mirror_uuid=" << mirror_uuid << ", " | |||
| << "predecessor_mirror_uuid=" << predecessor_mirror_uuid << ", " | |||
| << "replay_tag_tid=" << m_replay_tag_tid << " ," | |||
|
@trociny update pushed |
| ASSERT_EQ(0, ctx.wait()); | ||
| } | ||
|
|
||
| TEST_F(TestMockImageReplayerBootstrapRequest, SplinBrainForcePromote) { |
| predecessor_commit_valid ? "true" : "false"); | ||
| f->dump_unsigned("predecessor_tag_tid", predecessor_tag_tid); | ||
| f->dump_unsigned("predecessor_entry_tid", predecessor_entry_tid); | ||
| predecessor.dump(f); |
There was a problem hiding this comment.
@dillaman Add "predecessor" section here or "predecessor_" prefix for fields in TagPredecessor::dump? Otherwise the output might look confusing.
added 2 commits
August 16, 2016 09:09
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
added 6 commits
August 16, 2016 09:11
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
A non-primary image's commit possition won't accurately reflect the current demotion/promotion chain. Therefore, directly specify the predecessor for promotion events. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Fixes: http://tracker.ceph.com/issues/16855 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
@trociny updates pushed |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16855