Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: Remove trailing whitespace in usermod command (SUSE) #10707

Merged
merged 1 commit into from Nov 3, 2016

Conversation

tserong
Copy link
Contributor

@tserong tserong commented Aug 12, 2016

Trailing whitespace after the backslash on the -d line of the
usermod command effectively splits it in two, breaking the
rpm %pre script for SUSE builds.

Signed-off-by: Tim Serong tserong@suse.com

Trailing whitespace after the backslash on the -d line of the
usermod command effectively splits it in two, breaking the
rpm %pre script for SUSE builds.

Signed-off-by: Tim Serong <tserong@suse.com>
@tserong
Copy link
Contributor Author

tserong commented Aug 12, 2016

@smithfarm, mind reviewing? (My test build with this change is yet to complete, but it should be good... give me half an hour or so)

@smithfarm
Copy link
Contributor

smithfarm commented Aug 12, 2016

Good catch, @tserong! Note that this change is entirely within a SUSE conditional block, so it makes little sense to put it through gitbuilder. It fixes a regression introduced by b3dfa8d which was merged post-jewel.

Reviewed-by: Nathan Cutler <ncutler@suse.com>

@tserong
Copy link
Contributor Author

tserong commented Aug 12, 2016

Just to confirm, my test build with this change was OK.

@liewegas liewegas merged commit 1014850 into ceph:master Nov 3, 2016
@tserong tserong deleted the wip-fix-suse-usermod branch November 3, 2016 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants