rgw: remove the field ret from class RGWPutLC #10726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiqiaomiao
force-pushed
the
wqm-wip-remove-ret
branch
from
74cb3e1
to
b17e48f
Compare
|
Does not compile, see below: [ 96%] Building CXX object src/test/librbd/CMakeFiles/unittest_librbd.dir/object_map/test_mock_UnlockRequest.cc.o
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_rest.cc: In member function ‘virtual int RGWPutLC_ObjStore::get_params()’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_rest.cc:1193:15: error: ‘ret’ was not declared in this scope
return ret;
^
[ 96%] Building CXX object src/rgw/CMakeFiles/rgw_a.dir/rgw_rest_client.cc.o |
weiqiaomiao
force-pushed
the
wqm-wip-remove-ret
branch
from
b17e48f
to
bf67d78
Compare
remove the field ret from class RGWPutLC, because it should use op_ret which had defined in class RGWOp. Signed-off-by: weiqiaomiao <wei.qiaomiao@zte.com.cn>
weiqiaomiao
force-pushed
the
wqm-wip-remove-ret
branch
from
bf67d78
to
97007e4
Compare
|
@xiexingguo thanks. I have been fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the field ret from class RGWPutLC, because it should use op_ret which had defined in class RGWOp.
Signed-off-by: weiqiaomiao wei.qiaomiao@zte.com.cn