bluestore: initialize csum_order properly #10728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To kill the following warning:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/BlueStore.h:39:0,
from /home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/BlueStore.cc:22:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/bluestore_types.h: In member function ‘int BlueStore::_do_alloc_write(BlueStore::TransContext*, BlueStore::WriteContext*)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/bluestore_types.h:558:29: warning: ‘csum_order’ may be used uninitialized in this function [-Wmaybe-uninitialized]
csum_chunk_order = order;
^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/BlueStore.cc:6145:14: note: ‘csum_order’ was declared here
unsigned csum_order;
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
This is actually a compiler bug I think, since all paths initialie csum_order beofre using it, but this is safe enough. |
liewegas
pushed a commit
to liewegas/ceph
that referenced
this pull request
Nov 18, 2016
The package was renamed a long time ago (around the Fedora 15 timeframe). The "junit4" name is only relevant for EPEL 6. For EPEL 7 and Fedora 20, the "junit" package has "Provides: junit4". And most recently, in the junit package that ships in Fedora 21 and 22, the package maintainer dropped the old Provides: line. http://tracker.ceph.com/issues/10728 Fixes: ceph#10728 Signed-off-by: Ken Dreyer <kdreyer@redhat.com> Signed-off-by: Loic Dachary <ldachary@redhat.com> (cherry picked from commit 4f36eae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To kill the following warning:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/BlueStore.h:39:0,
from /home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/BlueStore.cc:22:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/bluestore_types.h: In member function ‘int BlueStore::do_alloc_write(BlueStore::TransContext, BlueStore::WriteContext_)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/bluestore_types.h:558:29: warning: ‘csum_order’ may be used uninitialized in this function [-Wmaybe-uninitialized]
csum_chunk_order = order;
^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/BlueStore.cc:6145:14: note: ‘csum_order’ was declared here
unsigned csum_order;
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn