Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg: make async backend default #10746

Merged
merged 1 commit into from Sep 2, 2016
Merged

msg: make async backend default #10746

merged 1 commit into from Sep 2, 2016

Conversation

yuyuyu101
Copy link
Member

Signed-off-by: Haomai Wang haomai@xsky.com

Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
Copy link
Member Author

@yuriw @tchaikov and others... I hope anyone who ran a lot of qa suites can pick up this pr.

@yuyuyu101
Copy link
Member Author

@yuriw
Copy link
Contributor

yuriw commented Aug 22, 2016

@yuyuyu101 it will be part of wip-yuri-testing2_2016_08_22 tests, pls remove DNM as you see fit

@yuriw
Copy link
Contributor

yuriw commented Aug 29, 2016

@yuyuyu101
Copy link
Member Author

@liewegas @athanatos would you think this is a good time point?

@yuriw
Copy link
Contributor

yuriw commented Aug 30, 2016

Caution - we saw some unit tests failing which we (Josh and me)
initially thought were not related to the PRs (and this one in
particular), and I'm not so confident now as all tests verified passed
on master yesterday.

1 - test-ceph-helpers.sh (Failed)
5 - cephtool-test-mon.sh (Failed)
14 - run-tox-ceph-disk (Failed)
15 - run-tox-ceph-detect-init (Failed)

@liewegas
Copy link
Member

liewegas commented Aug 30, 2016 via email

@yuyuyu101 yuyuyu101 changed the title DNM: msg: make async backend default msg: make async backend default Aug 31, 2016
@yuyuyu101
Copy link
Member Author

yes, I don't think the uniitests failed related to async msgr too. I guess cephfs's problem is related to process spawn? @tchaikov @jcsp

@yuriw
Copy link
Contributor

yuriw commented Aug 31, 2016

@jdurgin FYI ^

@jcsp
Copy link
Contributor

jcsp commented Aug 31, 2016

Is there a log of the cephfs failure mentioned here?

@liewegas
Copy link
Member

I just remember hearing something about it a few months ago. IIRC fast
dispatch related? @gregsfortytwo knows I think

@gregsfortytwo
Copy link
Member

It wouldn't have been fast dispatch for the FS; I think it was the command with the bad locking that Doug fixed.

@yuriw
Copy link
Contributor

yuriw commented Sep 1, 2016

unit tests failing b/c incorrect reg exp match issue, so tests actually passed per @jdurgin

related fix #10943

@yuriw
Copy link
Contributor

yuriw commented Sep 2, 2016

I am reclaiming wip-yuri-teting tag, place it back to queue if it needs retesting retesting

@yuyuyu101
Copy link
Member Author

Hmm, I guess we could merge now.

@liewegas liewegas merged commit 6df9577 into master Sep 2, 2016
@liewegas liewegas deleted the wip-async-default branch September 2, 2016 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants