Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: do not try to encode or decode time_t and fix compiling warnings #10751

Merged
merged 6 commits into from Aug 19, 2016
Merged

rgw: do not try to encode or decode time_t and fix compiling warnings #10751

merged 6 commits into from Aug 19, 2016

Commits on Aug 17, 2016

  1. rgw: do not try to encode or decode time_t 

    time_t is `signed int` on linux, which is ambiguous when encode() or decode() on i386-linux.
see also 8f9e7b0.

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Aug 17, 2016
    Copy the full SHA
    a98ddf7 View commit details
    Browse the repository at this point in the history

  2. cls_rgw: fix the compiler warning 

    fixes the warning of
```
warning:
/srv/autobuild-ceph/gitbuilder.git/build/out~/ceph-11.0.0-1566-ga98ddf7/src/objclass/objclass.h:35:72:
format ‘%lu’ expects argument of type ‘long unsigned int’, but argument
6 has type ‘std::basic_string::size_type {aka unsigned int}’ [-Wformat=]
cls_log(level, " %s:%d: " fmt, __FILE__, __LINE__, ##__VA_ARGS__)
^
/srv/autobuild-ceph/gitbuilder.git/build/out~/ceph-11.0.0-1566-ga98ddf7/src/cls/rgw/cls_rgw.cc:477:7:
note: in expansion of macro ‘CLS_LOG’
CLS_LOG(20, "start_key=%s len=%lu", start_key.c_str(),
start_key.size());
^
```

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Aug 17, 2016
    Copy the full SHA
    6c55d73 View commit details
    Browse the repository at this point in the history

  3. msg/async: fix compiler warnings 

    fix warnings like
```
comparison between signed and unsigned integer expressions
[-Wsign-compare]
```

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Aug 17, 2016
    Copy the full SHA
    20320f3 View commit details
    Browse the repository at this point in the history

  4. os/filestore: silence compiling warnings 

    silence warnings like
```
src/os/filestore/FileStore.h:55:27: comparison between signed and
unsigned integer expressions [-Wsign-compare]
^
/srv/autobuild-ceph/gitbuilder.git/build/out~/ceph-11.0.0-1566-ga98ddf7/src/os/filestore/BtrfsFileStoreBackend.cc:269:29:
note: in expansion of macro ‘BTRFS_SUPER_MAGIC’
if (currentfs.f_type == BTRFS_SUPER_MAGIC && basest.st_dev != st.st_dev)
{
^
```

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Aug 17, 2016
    Copy the full SHA
    dd54ea6 View commit details
    Browse the repository at this point in the history

  5. test/rbd: silence compiling warnings 

    silence warnings like:
```
src/test/librbd/fsx.cc:1589:21: comparison between signed and unsigned
integer expressions [-Wsign-compare]
(offset + size > monitorstart &&
^
```

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Aug 17, 2016
    Copy the full SHA
    7b9433c View commit details
    Browse the repository at this point in the history

  6. rgw: silence a compiling warning 

    printf() a uint64 in a portable way (i.e. C98 compliant way).

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Aug 17, 2016
    Copy the full SHA
    c59f402 View commit details
    Browse the repository at this point in the history