osd: bail out if transaction size overflows #10753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's talk about this in standup tomorrow. |
tchaikov
changed the title
|
will check if we have a guard for file journal because the transaction size could be greater than the size of file journal! |
tchaikov
changed the title
|
changelog
|
|
|
||
| // store new maps: queue for disk and put in the osdmap cache | ||
| epoch_t start = MAX(superblock.newest_map + 1, first); | ||
| for (epoch_t e = start; e <= last; e++) { | ||
| if (txn_size > t.get_num_bytes()) { | ||
| derr << __func__ << " transaction size overflowed" << dendl; | ||
| assert(txn_size > t.get_num_bytes()); |
There was a problem hiding this comment.
@tchaikov I think this assert has no effect(always true)?
with a large MOSDMap message, the transaction size could be greater than UINT_MAX. so fail early with error messages. Fixes: http://tracker.ceph.com/issues/16982 Signed-off-by: Kefu Chai <kchai@redhat.com>
if a transaction is too large to fit in the FileJournal's ring buffer, we will wait. but if its size is larger than the max_size, it's likely due to a bug or an invalid setting. in that case, we'd better fail earlier. Fixes: http://tracker.ceph.com/issues/16982 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
changelog
|
|
lgtm, adding needs-qa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with a large MOSDMap message, the transaction size could be greater than
UINT_MAX. so fail early with error messages.
Fixes: http://tracker.ceph.com/issues/16982
Signed-off-by: Kefu Chai kchai@redhat.com