os/bluestore: misc fixes #10771
Merged
os/bluestore: misc fixes #10771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a poorly named function.. the comment says // This asks the OS to initiate flushing the cached data to disk, so RangeStartFlush would have been better. In any case, it's not a data integrity call, so I think it's okay as it. What I want to avoid is flushing the same block twice... |
file_map should be accessed under the protection of the global lock. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
This assert is used to guarantee that we don't access violation but currently has no effect. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-fix-bluerockenv
branch
from
b9c12ef
to
d2cfbb9
Compare
xiexingguo
changed the title
|
@liewegas Dropped that change and appended more changes. |
| derr << __func__ << " allocated: " << allocated << \ | ||
| " offset: " << offset << " length: " << length << dendl; | ||
| derr << __func__ << " allocated: 0x" << std::hex << allocated | ||
| << " offset: 0x" << offset << " length: 0x" << length << std::dec |
There was a problem hiding this comment.
please include the std::dec at the end
There was a problem hiding this comment.
@liewegas Sir, I did... The std::dec lies at the end of this line.
|
otherwise lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shall round nbytes up to be page-size(4096) aligned instead of
truncating it down, as syncing more is usually okay
while syncing less indicates potential data loss.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn