libcephfs: add unmount function in cephfs.pyx

[renhwztetecs]

we need unmount function when change the mount point

Signed-off-by: huanwen ren ren.huanwen@zte.com.cn

[xiexingguo]

The failure is true:

Error compiling Cython file:
------------------------------------------------------------
...
            raise make_ex(ret, "error calling ceph_mount")
        self.state = "mounted"

    def unmount(self):
        if self.state == "mounted":
        with nogil:
       ^
------------------------------------------------------------

cephfs.pyx:485:8: Expected an increase in indentation level
Compiling cephfs.pyx because it changed.
Cythonizing cephfs.pyx
Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/cephfs/setup.py", line 189, in <module>
    os.path.join(os.path.dirname(__file__), "..", "rados")
  File "/usr/lib/python2.7/dist-packages/Cython/Build/Dependencies.py", line 798, in cythonize
    cythonize_one(*args[1:])
  File "/usr/lib/python2.7/dist-packages/Cython/Build/Dependencies.py", line 915, in cythonize_one
    raise CompileError(None, pyx_file)
Cython.Compiler.Errors.CompileError: cephfs.pyx
make[3]: *** [src/pybind/cephfs/CMakeFiles/cython_cephfs] Error 1
make[2]: *** [src/pybind/cephfs/CMakeFiles/cython_cephfs.dir/all] Error 2

[jcsp]

Surely you don't mean to construct cephfs and then call unmount on it immediately?

[renhwztetecs]

yeah，I think I understand the mistake before

[jcsp]

The "add unmount test" commit doesn't really seem to add a test, it just calls unmount at the end of existing test, right? Please could you add a test that mounts, does something, unmounts, then mounts again (using the same LibCephFS instance) and shows that the LibCephFS instance still works properly after the second mount.

[renhwztetecs]

add test_mount_unmount() test

[ajarr]

Please remove the extra blank lines at the end.

[ajarr]

@renhwztetecs , besides the comments looks OK.

[renhwztetecs]

@aakso
all done,thanks

[ajarr]

@renhwztetecs, the line still has a trailing whitespace.

[renhwztetecs]

I change it.

[ajarr]

Jenkins has failed due to,

Could NOT find Python3Interp: Found unsuitable version "2.7.5", but
required is at least "3" (found /usr/bin/python)
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:313 (_FPHSA_FAILURE_MESSAGE)
cmake/modules/FindPython3Interp.cmake:146 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
src/CMakeLists.txt:203 (find_package)

as already noted in http://www.spinics.net/lists/ceph-devel/msg32397.html

I tested the PR locally. The included test ran successfully.
http://pastebin.com/t1tNubvW

@jcsp, the test looks OK to you?

[ajarr]

LGTM