rgw ldap: protect rgw::from_base64 from non-base64 input #10777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds unit tests for: 1. empty output from from_base64 (turns out to be harmless) 2. random and specific non-base64 and sort strings Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
| try { | ||
| base64_token = rgw::from_base64(access_key_id); | ||
| } catch(...) { | ||
| base64_token = std::string(""); |
There was a problem hiding this comment.
base64_token is already in its default-constructed state, is this necessary?
There was a problem hiding this comment.
It feels cleaner to re-assert it in an empty state, at least to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds unit tests for:
Signed-off-by: Matt Benjamin mbenjamin@redhat.com