jewel: common: Request exclusive lock if owner sends -ENOTSUPP for proxied maintenance op #10784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial krbd implementation will not support executing maintenance ops and instead will return -EOPNOTSUPP. In this case, librbd can take the lock and execute the operation. Fixes: http://tracker.ceph.com/issues/16171 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit d2d2d90)
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 23, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 25, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 10, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 10, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 13, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 17, 2016
…ds -ENOTSUPP for proxied maintenance op Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@idryomov does this backport look good to merge ? It passed the rbd suite http://tracker.ceph.com/issues/17487#note-10 (except for two failures that are unrelated http://tracker.ceph.com/issues/17590 and http://tracker.ceph.com/issues/17262) |
|
Looks good. (As noted in the original PR, rbd suite doesn't exercise it - I ran a quick krbd test.) |
|
@idryomov sorry for missing that and thanks for testing. Next time feel free to just remind me I missed the relevant test and I'll do it. |
ghost
merged commit 
theanalyst
changed the title
theanalyst
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17067