os/bluestore: include bluefs space in statfs result #10795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-bluestore-statfs
branch
3 times, most recently
from
0822aaa
to
2c2333a
Compare
| assert(alloc->get_free() >= bluefs_len); | ||
| buf->available = (alloc->get_free() - bluefs_len); | ||
| buf->available = alloc->get_free(); | ||
|
|
There was a problem hiding this comment.
@liewegas Do we need the above as the below loop is counting usage for all device ? Probably, needed only if bluefs is not enabled ?
There was a problem hiding this comment.
@liewegas sorry, my bad , it is only collecting usage for all the devices for db/wal. We are good it seems..I will verify..
We were counting all (free) space allocated to bluefs as used. Instead, query bluefs to find out what is used and what is free. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore-statfs
branch
from
2c2333a
to
b97f3d6
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were counting all (free) space allocated to bluefs as used. Instead,
query bluefs to find out what is used and what is free.
Signed-off-by: Sage Weil sage@redhat.com